On Sun, Sep 25, 2011 at 07:28:17PM +0200, Jean-Yves Migeon wrote: > On 25.09.2011 16:27, Joerg Sonnenberger wrote: > >On Sun, Sep 25, 2011 at 04:02:04PM +0200, Jean-Yves Migeon wrote: > >>Unless someone objects (with arguments), I will commit this at the > >>end of the week and fix call sites to use the new macro; > >>KASSERTMSG() would then work like its man page suggests. > > > >Just to practical notes: > > > >(1) Please test that lint(1) is not stupid enough to bail out on it. > >(2) Kill the !__STDC__ branches. Preferable doing this first. > > (1) How do I check that? Run a distribution with MKLINT=yes would be enough?
make subr_prf.ln or so in the kernel build directory. It's just a useful to know case, not a show stopper (IMO) if lint doesn't support Yet Another Part Of C99. > (2) By "kill", you mean "remove"? There are a couple of other places > where __STDC__ is used (not with libkern.h though -- at least not > included in the source file explicitly). Yes, remove. !__STDC__ only makes sense for one cae in NetBSD -- things included and used by assembler. That's it. Joerg