Well. It's a backwards-incompatible change, that's for sure - but it is
one that in my humble opinion needs to be made. (We seem to agree about
that.)
Now, if I were to fix this I'd go ahead and allow the object reference
to have a prefix for this particular service. I would add binding
functionality and default the prefix to OGNL.
BUT in case the OGNL expression doesn't yield a valid result I'd assume
it's a literal string. If that doesn't yield a valid result either, I'd
assume it's an invalid OGNL expression.
The whole deal is of course simplified if you actually specify a binding
prefix. : )
Does this make sense? Would it be an acceptable way to solve the problem?
-Filip
Mike Snare skrev:
Ok. Now I see it. Thanks for the pointer.
I read the code and understand my problem. I definitely think this
should be fixed. The question is how?
It seems that since everyone is already assuming that they need to
specify a literal string for the name, it would be fine to simply make
literal: the default prefix for this, but allow other binding
prefixes.
The only problem with that is that now we have different default
prefixes for the page/jwc files in different elements. Again, that's
(apparently) the way it's always been, so maybe it's not a big deal.
If it does get fixed that way for, say, 4.0.2, I would recommend a
follow on action for the next backwards-INcompatible release to go
ahead and fix it so that the ognl: prefix is the default like all
other page/jwc file attributes.
Thanks for the help, and Happy Easter to you as well.
-Mike
On 4/13/06, Filip S. Adamsen <[EMAIL PROTECTED]> wrote:
Hi,
The problem here is that the "object" attribute is not resolved in the
InjectPageWorker class (have a look at
org.apache.tapestry.enhance.InjectPageWorker:66), so passing in anything
but a String will not yield a valid page name.
This should probably be fixed, although care must be taken not to break
backwards-compatibility, since you need to resolve the object - that is,
handle prefixes and so on - and this would require a "literal:" in front
of hardcoded page names.
I'm on my way out the door to visit some family - happy Easter, by the
way : ) - but will look into this and possibly provide a solution when I
get home later tonight.
-Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
