Re: [sysvinit-devel] insserv no longer understand X-Interactive: true

[Petter Reinholdtsen]

[Werner Fink]
> Please try out the attached patch

Thank you.  Kel proposed a very similar patch earlier today, which
worked for me.  Sorry I have been to busy to pass it on before now.

Description: Fix regular expression match for X-Interactive keyword, it was
 off-by-one match group and thus always returned 'X-'.
From: Kel Modderman <k...@otaku42.de>
---
--- a/insserv.c
+++ b/insserv.c
@@ -1378,10 +1378,10 @@ static uchar scan_lsb_headers(const int
                description = empty;
        }
 
-       if (!interactive    && regexecutor(&reg.interact,      COMMON_ARGS) == 
true) {
-           if (val->rm_so < val->rm_eo) {
-               *(pbuf+val->rm_eo) = '\0';
-               interactive = xstrdup(pbuf+val->rm_so);
+       if (!interactive    && regexecutor(&reg.interact,  COMMON_SHD_ARGS) == 
true) {
+           if (shl->rm_so < shl->rm_eo) {
+               *(pbuf+shl->rm_eo) = '\0';
+               interactive = xstrdup(pbuf+shl->rm_so);
            } else
                interactive = empty;
        }

Happy hacking,
-- 
Petter Reinholdtsen