Is this related to MODTOOLS-108 in Jira, which Michael just created a few days 
ago? See: http://tracker.crosswire.org/browse/MODTOOLS-108

If so, can you add the comment there. Otherwise can you find or create an 
appropriate issue in Jira in MODTOOLS?

Can you supply a mock osis xml that reliably goes into an infinite loop? I’ve 
heard reports of this but cannot reproduce.

I’m not sure what you meant by “do not exist in any of the SWORD 
versifications” as osis2mod only considers the versification that is supplied 
when running it.

The goal of osis2mod is to build a module, handling most errors as recoverable 
and giving exactly what recovery was provided. So in that sense, it should not 
stop.

When a book is not in the v11n, it is appended to the module, which means it is 
appended to the last verse of the chosen v11n.

Maybe a different message if the book or chapter is not in the versification? 
This would avoid calling out each verse that is not in the v11n.

Perhaps a flag for diagnostics only?

Maybe creating a histogram of repeated messages (don’t output the same message, 
one right after the other but rather buffer them with a count. When the new 
message is different from the last, output the last with a count. At the end of 
the program, output the outstanding buffered messages).

Maybe we need a separate tool to find the best v11n, of the known v11ns? I.e. 
the one with the least mismatches.

DM

> On Apr 1, 2025, at 2:19 AM, David Haslam <dfh...@protonmail.com> wrote:
> 
> If osis2mod encounters a set of osisID that do not exist in any of the SWORD 
> versifications - it appears to go into an endless loop attempting to link 
> each one to Rev.22.21
> 
> Wouldn’t it be preferable for it to fail with an error message? eg
> 
> INVALID osisID - cannot continue!
> 
> Best regards,
> 
> David
> 
> Sent from Proton Mail <https://proton.me/mail/home> for iOS
> _______________________________________________
> sword-devel mailing list: sword-devel@crosswire.org
> http://crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page

_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page

Reply via email to