> On Jun 4, 2018, at 11:17, Brad Davis <b...@freebsd.org> wrote: > > Author: brd > Date: Mon Jun 4 15:17:24 2018 > New Revision: 334617 > URL: https://svnweb.freebsd.org/changeset/base/334617 > > Log: > Move /sys symlink creating out of etc/Makefile. > > This is prep for etc/Makefile going away. > > Approved by: bapt (mentor) > > Modified: > head/Makefile.inc1 > head/etc/Makefile >
Aside from other objections, I don’t think /Makefile nor /Makefile.inc1 should “own” anything on the system and should only drive the build or other general targets for users to interact with. Please put this into something like /hier or better yet the existing directory handling that stuff /etc. (so a revert since simply moving everything to it via a rename or rewrite seems silly) > Modified: head/Makefile.inc1 > ============================================================================== > --- head/Makefile.inc1 Mon Jun 4 14:56:02 2018 (r334616) > +++ head/Makefile.inc1 Mon Jun 4 15:17:24 2018 (r334617) > @@ -1239,6 +1239,7 @@ distributeworld installworld stageworld: _installcheck > METALOG=${METALOG} ${IMAKE_INSTALL} ${IMAKE_MTREE} \ > DISTBASE=/base DESTDIR=${DESTDIR}/${DISTDIR}/base \ > LOCAL_MTREE=${LOCAL_MTREE:Q} distrib-dirs > + ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys > .endif > ${_+_}cd ${.CURDIR}; ${IMAKE} re${.TARGET:S/world$//}; \ > ${IMAKEENV} rm -rf ${INSTALLTMP} > > Modified: head/etc/Makefile > ============================================================================== > --- head/etc/Makefile Mon Jun 4 14:56:02 2018 (r334616) > +++ head/etc/Makefile Mon Jun 4 15:17:24 2018 (r334617) > @@ -386,7 +386,6 @@ distrib-dirs: ${MTREES:N/*} distrib-cleanup .PHONY > ${METALOG.add} ; \ > done; true > .endif > - ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys > .if ${MK_NLS} != "no" > set - `grep "^[a-zA-Z]" ${.CURDIR}/nls.alias`; \ > while [ $$# -gt 0 ] ; do \ > _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"