On 02 Nov 2016, at 08:25, Jonathan Anderson <jonat...@freebsd.org> wrote: > > On 1 Nov 2016, at 21:10, Dimitry Andric wrote: > >> Please note, I reverted r307823 (which changed the suffixes from .bco >> and .llo to .bc and .ll) in r308003, since it caused a number of ports >> failures. These ports were already using .ll as a suffix for C++ lex >> scripts. > > The changes to bsd.suffixes-posix.mk (included by sys.mk) would have affected > anything compiled with bmake, and indeed, I'd imagine that adding a .c->.ll > rule alongside .c->.o could cause problems with C++ lex rules. In fact, part > of brooks' original motivation for introducing .llo suffixes was to avoid > name conflicts (although conflicts with program IR like we're introducing in > this commit). The changes in this commit should only be picked up by things > that explicit include bsd.{lib,prog}.mk, however, and they also have slightly > more esoteric names (e.g., progname.full.ll) that are less likely to cause a > conflict. Perhaps I ought to have done an exp-run, but I suspect that this > commit will cause much less / no fallout. I don't suppose you have a list of > the ports that failed after your r307823 change so that I could do spot > checks?
Hi Antoine, you pointed me at some of these port failures due to the .ll change, do you still have a list of them? -Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail