Hi, On Jun 4, 2011, at 11:45, Andreas Tobler wrote: > The chip itself is not PowerMac specific. It contains four times the > functionality of the ad7418 which is already in there. (dev/iicbus) > > The ofw is only needed to detect the chip and to wire the sensor place to the > right fan property. I think this could be refactored that it is PowerMac only > and others could benefit from the driver too.
Right. Since iicbus(4) is a hinted bus, I believe the current scenario could be improved either by having a dynamic hints system (and an OFW specific layer that added hints about known devices at runtime) or perhaps an OFW iicbus subclass (didn't Nathan start on this in r186833?). > The same would apply for the ds1775.c and the max6690.c. Those chips are not > PowerMac only, they are simple i2c temp sensors. Agreed. > To get there, it would really be helpful if there are other people with non > PowerMac hardware who would have an interest in these drivers. > Then we could sit together, refactor and test. W/o the corresponding hardware > it seems a bit difficult for me to test. I'd love to help. I'll try getting my hands on the raw chips and wire them up to my glxiic(4) based lab setup. I'll get back to you then. Brix -- Henrik Brix Andersen <b...@freebsd.org>
PGP.sig
Description: This is a digitally signed message part
