Re: svn commit: r203800 - in head/tools: regression/file/newfileops_on_fork regression/gaithrstress tools/mctest tools/netrate/http tools/netrate/httpd tools/netrate/juggle

[Kostik Belousov]

On Fri, Feb 12, 2010 at 04:33:03PM +0000, Ruslan Ermilov wrote:
> Author: ru
> Date: Fri Feb 12 16:33:03 2010
> New Revision: 203800
> URL: http://svn.freebsd.org/changeset/base/203800
> 
> Log:
>   Fixed error checking of pthread(3) functions.
>   
>   PR:         143807
>   Submitted by:       pluknet (partly)
> 
> Modified:
>   head/tools/regression/file/newfileops_on_fork/newfileops_on_fork.c
>   head/tools/regression/gaithrstress/gaithrstress.c
>   head/tools/tools/mctest/mctest.cc
>   head/tools/tools/netrate/http/http.c
>   head/tools/tools/netrate/httpd/httpd.c
>   head/tools/tools/netrate/juggle/juggle.c
> 
> Modified: head/tools/regression/file/newfileops_on_fork/newfileops_on_fork.c
> ==============================================================================
> --- head/tools/regression/file/newfileops_on_fork/newfileops_on_fork.c        
> Fri Feb 12 15:07:24 2010        (r203799)
> +++ head/tools/regression/file/newfileops_on_fork/newfileops_on_fork.c        
> Fri Feb 12 16:33:03 2010        (r203800)
> @@ -113,7 +113,7 @@ main(__unused int argc, __unused char *a
>               err(-1, "bind");
>       if (listen(listen_fd, -1) <0)
>               err(-1, "listen");
> -     if (pthread_create(&accept_thread, NULL, do_accept, NULL) < 0)
> +     if (pthread_create(&accept_thread, NULL, do_accept, NULL) != 0)
>               err(-1, "pthread_create");
>       sleep(1);       /* Easier than using a CV. */;
>       do_fork();

err() uses errno, so this is still not quite right ?

pgp6YxOtgyJO1.pgp
Description: PGP signature