On 01/12/2013 10:56, Adrian Chadd wrote: > Hi, > > I think this outlines a larger scale problem here, which is that way, > way too many things are relying on maxfiles here and it wasn't > properly reviewed or thought out before it made it into the tree. > > So, can we either: > > * review _all_ the places maxfiles is being used, and finally fix those; > * .. or revert this work until said review and fixup is done? > > This is the kind of thing that we should just not mess up at this point..
At this point, I think reverting the changes would be an overreaction. Moreover, the change that I just made to vmparam.h on MIPS should arguably have been made when 64-bit support was added to MIPS. For example, if someone had tried running ZFS on a 64-bit MIPS processor just a few weeks or months ago, we would have discovered that the same change was required. In other words, the autoconfiguration changes are bringing to light some problems that have been lurking within the param.h and vmparam.h files on some of the non-x86/sparc64 platforms. Alan P.S. That said, I think we should exercise much caution in MFCing these changes. _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
