On Wednesday, October 17, 2012 11:26:21 am Maksim Yevmenkin wrote: > On Wed, Oct 17, 2012 at 6:51 AM, John Baldwin <j...@freebsd.org> wrote: > > [...] > > >> > Maybe a helper 'if_set_baudrate(ifp, IF_Gbps(10))' that would DTRT. > >> > (It could be a static inline or some such). I would just like to > >> > keep the readability. > >> > >> well, yes, i thought about it, but decided not to do it right away. we > >> could provide shortcuts/macros for "popular" baudrates, i.e. 1, 10, 40 > >> and 100 Gbps. while ixgbe(4) example is not ideal, i thought it still > >> was pretty readable :) > > > > I don't really find it all that readable. IF_Gbps(1) looks like a typo > > to a casual reader. I really think you should have something like: > > [...] > > very well :) would something like (please see below) work?
Looks good to me. Thank you. :) -- John Baldwin _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
