On Sun, May 27, 2018, at 01:09, Alexey Dokuchaev wrote:
> On Fri, May 25, 2018 at 07:36:26PM +0000, Mark Felder wrote:
> > New Revision: 334221
> > URL: https://svnweb.freebsd.org/changeset/base/334221
> >
> > Log:
> > rc.subr: Support loading environmental variables from a file
> >
> > + if [ -n "$_env_file" ] && [ -r "${_env_file}" ]; then
>
> Style bug: "$_env_file" vs. "${_env_file}". Also, isn't the -n check
> redundant?
The entire rc.subr file seems to be full of style inconsistencies. I'd take the
time to fix it if there would be no objections. As per redundancy, it's
copy+paste of what mat suggested. I suppose the -r will fail if the variable is
not set, so it would indeed be redundant. I didn't think of it that way.
>
> > + set -a
> > + . $_env_file
>
> Shouldn't it be quoted here as well (. "$_env_file")?
>
It wouldn't hurt
Sorry about the late reply. I had a mistake in my sieve filters sending my mail
to a wrong folder.
--
Mark Felder
ports-secteam & portmgr member
f...@freebsd.org
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
