On Fri, May 25, 2018 at 07:36:26PM +0000, Mark Felder wrote:
> New Revision: 334221
> URL: https://svnweb.freebsd.org/changeset/base/334221
>
> Log:
> rc.subr: Support loading environmental variables from a file
>
> + if [ -n "$_env_file" ] && [ -r "${_env_file}" ]; then
Style bug: "$_env_file" vs. "${_env_file}". Also, isn't the -n check
redundant?
> + set -a
> + . $_env_file
Shouldn't it be quoted here as well (. "$_env_file")?
./danfe
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
