On 2016-12-29 06:38:10, Rodney W. Grimes wrote:
Author: tuexen Date: Thu Dec 29 11:32:42 2016 New Revision: 310773 URL: https://svnweb.freebsd.org/changeset/base/310773Log: MFC r310590: Whitespace changes. The toolchain for processing the sources has been updated. No functional change.What tool chain? It is still broken in at least 1 respect:
It's indent(1) from FreeBSD HEAD.
/* now use the rest of the mbuf chain for the text */ while (m_tmp != NULL) { if ((SCTP_BUF_NEXT(m_tmp) == NULL) && trailer) { - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset,^^^^^^^^^^^^^^SCTP_BUF_LEN(m_tmp) - (trailer + m_offset)); } else { - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset,^^^^^^^^^^^SCTP_BUF_LEN(m_tmp) - m_offset); }... others errors of this type occur in this patch.
This is caused by an old bug in indent that hasn't presented itself until -ta was used to automatically recognize tokens ending with "_t" as type names.
I think it would of been better to revert the old patch that messed up some comments before creating this change as now there are other changes intermingled making the 2 changes inter-dependent.
Two things have changed since that old patch that you refer to: 1) newest version of FreeBSD indent(1) was used 2) the option -ta was added It's the 1) that fixed comment formatting (broken earlier by me) since the old patch. It's the 2) that is responsible for some of the corrections that you applaud. It's also 2) that is responsible for uncovering the old bug in indent that I haven't fixed yet.
Even with this small nit, I applaud the number of style(9) corrections! -- Rod Grimes rgri...@freebsd.org
signature.asc
Description: PGP signature
