On Tue, Apr 21, 2009 at 02:54:36PM -0400, David Schultz wrote: > On Mon, Apr 20, 2009, Roman Divacky wrote: > > Author: rdivacky > > Date: Mon Apr 20 18:19:38 2009 > > New Revision: 191330 > > URL: http://svn.freebsd.org/changeset/base/191330 > > > > Log: > > Implement highlighting of today in month view of cal/ncal just like > > gnu cal does. This is currently disabled for year view because of hard > > coded padding in that case. This will hopefully be fixed soon. > > As I recall, ncal relies on the length of each line it formats to > take care of alignment issues in various places. Are you sure that > adding control characters doesn't break that?
yes, thats why the year printing is disabled (because the highlighting didnt work there) > Also, before this change, ncal was already full of convoluted > buffer handling, arbitrary buffer sizes, and little to no bounds > checking. This commit adds more magic numbers and fragile buffer > handling code, and generally makes an already hairy program even > less scrutable. This isn't your fault, but it would be nice if we > could make ncal better before it gets much worse. For instance, > you might use snprintf() or asprintf() instead of an extra half > dozen calls to memcpy() with various offsets. yes, thats true. do you want me to revert this? I am perfectly fine with having locally modified cal that supports this highlighting and not share this with world at all. _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
