xkaraman left a comment (kamailio/kamailio#4297)
> The note seems to be for `allow_[source_]address_group()` because it says
> `which was previously the entry with the lowest group ID`. For
> `allow_[source_]address()`, the matching is within same group, but still can
> be different network prefixes. Maybe that parenthesis should be removed or
> clarified is for the get-the-group functions.
>
Ah good catch, yes i should clarify that about the group variants.
> I also see you mentioned the version 6.0.3, I am not sure about backporting,
> is it considered a bug fix? I guess this has to be discussed in a larger
> group. Or add a mod param, defaulting to old behaviour and backport in 6.0
> and then switch to the new behaviour in 6.1, so nobody has unexpected
> surprises after upgrading within 6.0.x series in the future.
>
No, not a bug fix. Just confused and wrote it for the next release, but didn't
consider if its a bug. I will change to 6.1.x or maybe remove it completerly.
> Also, instead of having the note for each function, maybe is better added to
> the section at the top about address permissions:
>
> *
> https://www.kamailio.org/docs/modules/stable/modules/permissions.html#sec-address-permissions
Hmm, yeah could do it there as well, but will it be read if someone goes
directly to the function doc? Maybe if i add link to it as the note in
functions.
> Thinking more about it, a modparam would be good to have anyhow, because the
> PR has also impact on performance.
>
> Instead of returning on first match, now all the records are tried always,
> so, for example, even when the match would be the 1st or the 10th within 100
> records, all the 100 records are tried to see if there is a longer match.
Yeah that's true. Not sure if it's noticable in that range of records, but for
a lot more it might be a problem.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4297#issuecomment-3013858426
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4297/c3013858...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
