miconda left a comment (kamailio/kamailio#4297)
The note seems to be for `allow_[source_]address_group()` because it says
`which was previously the entry with the lowest group ID`. For
`allow_[source_]address()`, the matching is within same group, but still can be
different network prefixes. Maybe that parenthesis should be removed or
clarified is for the get-the-group functions.
I also see you mentioned the version 6.0.3, I am not sure about backporting, is
it considered a bug fix? I guess this has to be discussed in a larger group. Or
add a mod param, defaulting to old behaviour and backport in 6.0 and then
switch to the new behaviour in 6.1, so nobody has unexpected surprises after
upgrading within 6.0.x series in the future.
Also, instead of having the note for each function, maybe is better added to
the section at the top about address permissions:
-
https://www.kamailio.org/docs/modules/stable/modules/permissions.html#sec-address-permissions
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4297#issuecomment-3013373292
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4297/c3013373...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
