@henningw commented on this pull request.
> @@ -236,7 +236,7 @@ int diameter_peer_start(int blocking)
int seed;
peer *p;
- seed = random();
+ seed = kam_rand();
It depends what the child processes actually use then in their code. The code
in pt.c seeds all three as the different modules uses a lot of different
functions. This is usually not needed in individual module new processes.
My other point was that the change here does not change anything regarding the
functionality, besides silence a warning. Of course its still better to use the
kam_rand() as a policy, to allow easier auditing or later changes.
```
core/rand/kam_rand.h
31:#define kam_rand(x) rand(x)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4030#discussion_r1848422309
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4030/review/2445569...@github.com>_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the
sender!
