@vingarzan commented on this pull request.


> @@ -236,7 +236,7 @@ int diameter_peer_start(int blocking)
        int seed;
        peer *p;
 
-       seed = random();
+       seed = kam_rand();

Do we need though cryptographically secure seeding of the random though? I 
looked now in core/pt.c and there seem to be 3 things seeded there... I'd say 
that, if all 3 should be seeded after forking, then we should extract that code 
as a function, maybe even have a Kamailio-fork-function to do all of these. 
Anyway, this PR only tries to fight the immediate fires, not do such deeper 
changes.

It looks like the old code here is only seeding the child processes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4030#discussion_r1848411797
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4030/review/2445551...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to