@xkaraman commented on this pull request.
> @@ -3549,6 +3606,10 @@ static int rtpp_test(struct rtpp_node *node, int
> isdisabled, int force)
return 1;
}
if(force == 0) {
+ /* If ping_interval is set, the timer will ping and test
+ the rtps. No need to do something during routing */
+ if(rtpengine_ping_interval > 0)
+ return 1;
I am currently thinking that if a forced ping is required, regardless of ticks,
disabled or not, and so on, the function `rtpp_test_ping` should be used. It
does exactly that and only that.
So for
1. It seems to be ok.
2. We should use the function above instead of `rtpp_test()`
Thoughts on this?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4016#discussion_r1838173666
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4016/review/2429716...@github.com>_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
