@stefan-mititelu-idt commented on this pull request.
> @@ -3549,6 +3606,10 @@ static int rtpp_test(struct rtpp_node *node, int
> isdisabled, int force)
return 1;
}
if(force == 0) {
+ /* If ping_interval is set, the timer will ping and test
+ the rtps. No need to do something during routing */
+ if(rtpengine_ping_interval > 0)
+ return 1;
I like this change, but I think you should still place it inside "if (force==0)
{" condition. Otherwise, when timer pinging is enabled, will cancel all the
forced pings of rtpp_test(). More specifically will cancel the effect of (at
least) these 2 modparams:
1. aggressive_redetection -> maybe should still be ok since the purpose of the
timer pinging is to disable pinging done by the routing processes, but I think
should be documented
2. ping_mode -> rtpengines won't be able to be pinged first time when kamailio
starts, but will be pinged first time when timer triggers (e.g. after the
initial rtpengine_ping_interval seconds). Will all be considered available
untill that. Please check the child_init()->build_rtpp_socks()->rtpp_test()
flow for this.
Please let me know what you think about this.
Thanks,
Stefan
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4016#discussion_r1838081619
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4016/review/2429564...@github.com>_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
