@ivanuschak - related to:

```
-                       *from = &si->su;
+                       memcpy(*from, &si->su, sockaddru_len(si->su));
```

What I wanted to comment about is that the size are different between the 
pointer to a structure and the structure itself. A pointer is 4 bytes on 32bit 
CPU and 8 bytes on 64bit CPU. So the `&si->su` is a pointer (address), being 
4/8bytes, `*from` is written with 4/8 bytes.

The change makes the `*from` to be written with `sockaddru_len(si->su)` bytes. 
Is this correct in the way that `*from` has the proper reserved/allocated size? 
For me it feels incorrect, the `struct sockaddr_in6` is more than 8 bytes:

  - https://man7.org/linux/man-pages/man7/ipv6.7.html



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3925#issuecomment-2262083198
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3925/c2262083...@github.com>
_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

Reply via email to