Re: [Spice-devel] [PATCH 1/1] Fixes compilation error of Spice Client (Linux/X11) with OpenGL enabled modified: client/x11/red_window.cpp

[Hans de Goede]

Hi,

On 01/04/2011 04:13 PM, Marc-André Lureau wrote:

On Wed, Dec 22, 2010 at 2:08 PM, Thomas Tyminski
<thom...@cs.tu-berlin.de>  wrote:

diff --git a/client/x11/red_window.cpp b/client/x11/red_window.cpp
index d7b19f9..d53a92f 100644
--- a/client/x11/red_window.cpp
+++ b/client/x11/red_window.cpp
@@ -2075,13 +2075,13 @@ bool RedWindow::get_mouse_anchor_point(SpicePoint&  pt)
  #ifdef USE_OGL
  RedGlContext RedWindow::create_context_gl()
  {
-    RedGlContext *context = NULL;
     if (XPlatform::get_fbconfig()[_screen]) {
         XLockDisplay(x_display);
-        context = glXCreateContext(x_display, XPlatform::get_vinfo()[_screen], 
NULL, GL_TRUE);
+        RedGlContext context = glXCreateContext(x_display, 
XPlatform::get_vinfo()[_screen], NULL, GL_TRUE);
         XUnlockDisplay(x_display);
+        return context;
     }
-    return context;
+    return NULL;
  }

  RedPbuffer RedWindow::create_pbuff(int width, int height)

ACK

Thanks for the patch and the review! I've pushed this patch to
the spice master git repo.

Regards,

Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel