On Mon, Dec 20 07:56:42 PST 2010, alevy atredhat.com wrote:
> On Mon, Dec 20, 2010 at 04:29:21PM +0100, thom...@cs.tu-berlin.de wrote:
>> Hi,
>> I tried to compile the latest ( master branch ) Spice Client for
>> Linux/X11
>> with OpenGL.
>> I encountered compiling errors in the client/x11/red_window.cpp.
>>
>> This fix it for me:
>> //PATCH BEGIN
>>
>
> Thanks for the patch. If you use git format-patch and then git send-email
> it will be
> easier to apply. Also if you could remove commented out code (no reason to
> keep it
> around if it is wrong, that's what git is for).
>
All done, sent the Mail to spice-de...@lists.freedesktop.org.
>> client/x11/red_window.cpp | 7 ++++---
>> 1 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/client/x11/red_window.cpp b/client/x11/red_window.cpp
>> index d7b19f9..4ac48ca 100644
>> --- a/client/x11/red_window.cpp
>> +++ b/client/x11/red_window.cpp
>> @@ -2075,13 +2075,14 @@ bool
>> RedWindow::get_mouse_anchor_point(SpicePoint&
>> pt)
>> #ifdef USE_OGL
>> RedGlContext RedWindow::create_context_gl()
>> {
>> - RedGlContext *context = NULL;
>> + // RedGlContext *context =NULL ;
>> if (XPlatform::get_fbconfig()[_screen]) {
>> XLockDisplay(x_display);
>> - context = glXCreateContext(x_display,
>> XPlatform::get_vinfo()[_screen], NULL, GL_TRUE);
>> + RedGlContext context = glXCreateContext(x_display,
>> XPlatform::get_vinfo()[_screen], NULL, GL_TRUE);
>> XUnlockDisplay(x_display);
>> + return context;
>> }
>> - return context;
>> + return NULL;
>> }
>>
>> RedPbuffer RedWindow::create_pbuff(int width, int height)
>>
>> //PATCH END
>>
>> Changes are based on changes introduced in:
>> [PATCH spice] spicec-x11: Put locks around xlib calls which wait for a
>> reply
>> I used/tried on Fedora 14 x68_64 (2.6.35.9-64.fc14.x86_64).
>>
>> Something complete different now, did you remove the qemu monitor spice
>> commands? All spice.X (eg. spice.stat) commands are not working in my
>> build. Did I have to active them with some compile or configure flag?
>>
>
> What qemu branch are you using? the spice commands have been changed, but
> are still there. I'll try to find if we actually documented this
> somewhere.
>
> Alon
>
I checked out v24.
Greetings & happy holidays
Thomas Tyminski
Berlin , Germany
>> Greetings & happy holidays
>> Thomas Tyminski
>> Berlin , Germany
>>
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
