> OK, I've located the leak, and getting strong deja-vu *sigh*. I fixed > this in PerMsgStatus - it's the usage of 'main' to get back to > Mail::SpamAssassin, this time in Mail::SpamAssassin::Conf. People - > circular refs are bad, m'kay? > > But I'm not including a patch, because I'm not entirely sure what the > right patch is. The reason 'main' is used in Conf.pm is to access > sed_path(). But I see absolutely no reason for sed_path to be an object > method. It should either be a class method (i.e. called as > Mail::SpamAssassin->sed_path()) or it should be a plain function, and > perhaps put into an @EXPORT_OK list so you can import it. > > What would people prefer? I'd personally go for the function + > @EXPORT_OK method.
hmm, I prefer class methods, but I don't have too many problems with it. But is that really the only use of 'main' in Conf? seems wierd. --j. _______________________________________________ Spamassassin-talk mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/spamassassin-talk
