On 2020/01/10 13:13, Jason Thorpe wrote:
>
>
>> On Jan 9, 2020, at 6:11 PM, Masanobu SAITOH <msai...@execsw.org> wrote:
>>
>>
>> Before my change, struct stge_softc is already in if_stgereg.h,
>> so I had thought it would be OK to move to it.
>
> Ah, I don't think I would have put it there when I wrote the driver
> originally, so it must have been moved there at some point.
Oh, it was me :)
http://mail-index.netbsd.org/source-changes/2019/10/07/msg109768.html
> In any case, moving it into if_stgereg.h was also an error.
>
>>
>>> Please move them back to if_stge.c. Doing incorrect things simply to
>>> reduce the diff against someone else's copy of the code is not something we
>>> should be undertaking.
>> Two options:
>>
>> a) Move some structs (including struct stge_softc) and defines
>> to if_stge.c
>
> There is no reason to have if_stgevar.h, because no other modules need these
> definitions, so it should all move to if_stge.c.
The reason why I moved stge_softc to if_stgereg.h was that ipgphy.c
required to check stge's chip revision. So, if there is no any objection,
I'll make new if_stgevar.h and share it with if_stge.c and ipgphy.c.
> Thanks!
>
>>
>> b) Move them to new if_stgevar.h
>>
>> Which one is prefer?
>
> -- thorpej
>
--
-----------------------------------------------
SAITOH Masanobu (msai...@execsw.org
msai...@netbsd.org)
