On 2020/01/09 23:08, Jason Thorpe wrote:
>
>
>> On Jan 9, 2020, at 2:54 AM, SAITOH Masanobu <msai...@netbsd.org> wrote:
>>
>> Module Name: src
>> Committed By: msaitoh
>> Date: Thu Jan 9 10:54:16 UTC 2020
>>
>> Modified Files:
>> src/sys/dev/pci: if_stge.c if_stgereg.h
>>
>> Log Message:
>> Reduce diff against OpenBSD. No functional change.
>>
>> - USE CSR_{READ,WRITE}_*() macro.
>> - Move some macros from if_stge.c to if_stgereg.h
>
> This diff is incorrect.
Yes. You're right.
> The macros that were moved to if_stgereg.h are not related to hardware /
> register definitions, but are purely software constructs.
Before my change, struct stge_softc is already in if_stgereg.h,
so I had thought it would be OK to move to it.
> Please move them back to if_stge.c. Doing incorrect things simply to reduce
> the diff against someone else's copy of the code is not something we should
> be undertaking.
Two options:
a) Move some structs (including struct stge_softc) and defines
to if_stge.c
b) Move them to new if_stgevar.h
Which one is prefer?
> -- thorpej
>
--
-----------------------------------------------
SAITOH Masanobu (msai...@execsw.org
msai...@netbsd.org)
