Re: CVS commit: src/sys/kern

[Maxime Villard]

Le 25/07/2014 16:47, David Holland a écrit :
> 
> On Fri, Jul 25, 2014 at 11:21:47AM +0200, Maxime Villard wrote:
>  > > Log Message:
>  > > Add fdiscard and posix_fallocate syscalls.
>  > 
>  > I think 'error' instead of 'result' is better; it makes clear that it's
>  > an error code, and it's consistent with the other functions in the file.
> 
> !
> 
> If you care that much, change it...
> 

Also,

        
http://pubs.opengroup.org/onlinepubs/009695399/functions/posix_fallocate.html

indicates that

        The posix_fallocate() function shall fail if:
        [...]
        [EINVAL]
            The len argument was zero or the offset argument was less than zero.

but AFAICT there's no len == 0 check.

4718    if (pos < 0 || len < 0 || len > OFF_T_MAX - pos) {
4719            return EINVAL;
4720    }