On Fri, Jan 08, 2010 at 12:07:08PM +0000, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Fri Jan 8 12:07:08 UTC 2010 > > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > Simplify device G/C: use global list and config_alldevs_unlock_gc().
I see what you're trying to do here, and I appreciate the thought behind it, and savings in lines of code, but this is not the right way. Previously, the code distinguished garbage collection, locking acquisition, and resource-reclamation from each other by using more, and more meaningful, subroutine names. Also, in the common case, it collected and reclaimed garbage immediately at the end of config_detach(9) instead of at some arbitrary time in the future (for example, in the next call to device_lookup()). Your change obfuscates the code and needlessly postpones a lot of garbage collection. Please back it out. Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 278-3933
