Michael van Elst <mlel...@serpens.de> wrote:
> On Sun, Jan 03, 2010 at 08:58:37AM -0800, Matt Thomas wrote:
> > > Log Message:
> > > drop __predict micro optimization in pool_init for cleaner code.
> >
> > This change should be backed out. __predict_{true,false} are not only
> > micro optimizations, they also document behavior of the program.
>
> <...>
>
> If the code needs clarification, then about the fact that pools
> are used before the pool subsystem (in particular the locks)
> are initialized and 'cold' is queried as a crude workaround.
Agree with Matt, apart from micro-optimisation, it shows the behaviour or
common path. I do not think it hits readability, rather improves.
--
Mindaugas
