On Mon, 7 Sep 2026 12:18:31 GMT, Sergey Nazarkin <[email protected]> wrote:

>> I would like to finish the activity started by Man Cao [1] as we received 
>> several requests to support the dump over a network socket.   The original 
>> review stopped at the point where we needed to decide how to resolve the 
>> issue with the unmounted VT. Since none of the proposed solutions are 100% 
>> compatible with third-party HPROF tools, I opted for the simplest solution 
>> [2], which allows HPROF_HEAP_DUMP_SEGMENT to be mixed with HPROF_FRAME or 
>> HPROF_TRACE, breaking the linear sequence of top-level records. The related 
>> change is on line 
>> [2845](https://github.com/openjdk/jdk/pull/32733/changes#diff-bafe67cb93d9f50eb036e2aef63577ae58e78443343d6316251a6a283f398bcfR2845).
>> 
>> I’m still considering adding a guard option, such as `StrictSingleFileDump`, 
>> to explicitly enable the new behavior. Otherwise, the changes will 
>> automatically take effect on single-core instances. 
>> 
>> I have also refactored the original fix by moving all the segment writer 
>> code into a separate function. It should now look cleaner. 
>> 
>> Testing:
>> 1. tier1 on release build
>> 2. jtreg:test/hotspot/jtreg/serviceability on fast debug build
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>> 
>> [1] https://github.com/openjdk/jdk/pull/18160
>> [2] https://github.com/openjdk/jdk/pull/18160#issuecomment-1985383273
>
> @jianglizhou @alexmenkov Could you please review the changes when you have 
> time?

@snazarkin , would it make sense to add an explicit test case for this to avoid 
future regression and make intent clear? something like:

1. create a temp directory, create a fifo/pipe, set permissions to read-only on 
the directory. Or, tcp stream/etc would work.
2. launch a thread to read from the pipe and place it to a fs (different 
location)
3. run a jcmd->jvm heapdump writing to the pipe location
4. verify the produced heapdump is complete

Any temp files cannot be created since directory is read-only, and the contents 
of the pipe can be verified to have come through the pipe correctly in one shot.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32733#issuecomment-6839677753

Reply via email to