On Thu, 5 Nov 2026 06:24:20 GMT, Ioi Lam <[email protected]> wrote:
>> This PR renames a few C++ APIs that refer to the AOT configuration and AOT
>> cache to improve source code consistency:
>>
>> "preimage" -> "aot configuration"
>> "final image" -> "aot cache"
>>
>> Also, the class `FinalImageRecipes` is renamed to `AOTMetaspaceRecipes`, as
>> it contains only "recipes" for optimizing metaspace objects such as
>> `InstanceKlass` and `ConstantPool`. (E.g., Recipes for compiler
>> optimizations are stored in `trainingData.hpp`.).
>>
>> The main changes are in
>>
>> - aotMetaspace.hpp
>> - aotMetaspaceRecipes.hpp
>> - cdsConfig.hpp
>> - filemap.hpp
>> - filemap.cpp
>>
>> The changes in other files are simply renaming of function names, as well as
>> comment updates.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ioi Lam has updated the pull request incrementally with one additional commit
> since the last revision:
>
> @JnRouvignac comment: fixed typo
src/hotspot/share/cds/cppVtables.cpp line 235:
> 233: //
> 234: // _archived_cpp_vtptrs is a map of all the vptprs used by classes in an
> input archive. E.g., for
> 235: // InstanceKlass* k = a class loaded from the input archive;
What is "input archive"? Is it AOT config or AOT cache?
src/hotspot/share/cds/filemap.cpp line 561:
> 559:
> 560: bool is_classic_static_archive_or_aot_cache() const {
> 561: return _header->_magic == CDS_ARCHIVE_MAGIC;
Should we separate these 2 kinds of archive?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33734#discussion_r4484543778
PR Review Comment: https://git.openjdk.org/jdk/pull/33734#discussion_r4484558223
