On Mon, 2 Nov 2026 03:44:44 GMT, Long Yang <[email protected]> wrote:
>> @yanglong1010 @y1yang0 Just a reminder that hotspot changes require two >> reviewers. Also, it is best to make sure an Oracle engineer is involved. I >> usually run changes like this through some Oracle CI testing to make sure >> there are no issue. And lastly, I don't see any mention of test coverage for >> this. Is it possible to add a test case that would fail without these >> changes? Thanks. > > @plummercj Sorry for the trouble, and thanks for taking the time to point > this out, and I apologize for the process issues. > > I was not aware that hotspot changes require two reviewers with at least one > Oracle engineer involved. I will make sure to follow this convention in the > future. If it helps, I am happy to have this change re-reviewed, run through > Oracle CI, or reverted if needed. > > Regarding test coverage: I ran the existing tests under > test/hotspot/jtreg/serviceability/sa on amd64 and aarch64, but I did not add > a new targeted test. I will investigate whether a reproducible test case is > feasible and follow up. @yanglong1010 No need to revert or re-review. The changes seem to be passing our CI. Having an Oracle engineer do a review is not a requirement, but is recommended since they can help test with Oracle's CI if the changes warrant it, and reduce the risk of introducing issues. If you can find a test case that reproduces the problem, please create a PR to add it. Otherwise you can add the `noreg-hard` label to the CR to indicate that there is no regression test for this CR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33620#issuecomment-6580402709
