On Fri, 23 Oct 2026 17:21:29 GMT, Chris Plummer <[email protected]> wrote:
>> In the linux pathmap_open() you can see a check to make sure that SA_ALTROOT >> is not too big. This check is missing on macosx, leading to the possibility >> of a crash if SA_ALTROOT is too long. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > fix comment typo Marked as reviewed by sspitsyn (Reviewer). The fix is good in general. I've posted some questions and suggestion? test/hotspot/jtreg/serviceability/sa/TestLongAltRootPath.java line 4: > 2: * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. > 3: * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. > 4: */ Why is this strange copyright header? Should it be a usual OpenJDK header? test/hotspot/jtreg/serviceability/sa/TestLongAltRootPath.java line 26: > 24: * @requires vm.hasSA > 25: * @requires vm.gc != "Z" > 26: * @requires os.family != "windows" Q: Do we have to exclude sanitizer with ? : * @requires !vm.asan * @requires !vm.ubsan test/hotspot/jtreg/serviceability/sa/TestLongAltRootPath.java line 71: > 69: // Launch "jhsdb jstack" on the core file. > 70: ProcessBuilder pb = new ProcessBuilder(cmdStringList); > 71: SATestUtils.addPrivilegesIfNeeded(pb); Q: Why would we need additional privileges? ------------- PR Review: https://git.openjdk.org/jdk/pull/33520#pullrequestreview-5675269845 PR Comment: https://git.openjdk.org/jdk/pull/33520#issuecomment-6455227040 PR Review Comment: https://git.openjdk.org/jdk/pull/33520#discussion_r4394889374 PR Review Comment: https://git.openjdk.org/jdk/pull/33520#discussion_r4394915153 PR Review Comment: https://git.openjdk.org/jdk/pull/33520#discussion_r4394904004
