On Thu, 15 Oct 2026 03:44:37 GMT, Dingli Zhang <[email protected]> wrote:
>> Long Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add try/catch for memory-read exceptions in getSenderFP > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/riscv64/LinuxRISCV64CFrame.java > line 174: > >> 172: ? null >> 173: : fp().getAddressAt(C_FRAME_LINK_OFFSET * >> VM.getVM().getAddressSize()); >> 174: } > > Could `getSenderFP()` catch the same memory-read exceptions as > `getSenderPC()`? It is called before the `senderPC == null` check, so an > invalid FP can throw even after `getSenderPC()` has returned null to > terminate the walk. Pushed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33374#discussion_r4306047377
