On Thu, 15 Oct 2026 22:34:32 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Close library FD when lib_info is destroyed >> - Consider 64bit DWARF > > src/jdk.hotspot.agent/linux/native/libsaproc/ps_proc.c line 414: > >> 412: // we don't need to keep the library open, symtab is already >> 413: // built. Only for core dump we need to keep the fd open. >> 414: close(lib->fd); > > Why is this removed? Isn't it causing fd leaks? We need to keep FD because it might be used later if SA needs to read `.debug_frame`. Close the FD when `lib_info*` is destroyed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33375#discussion_r4292367353
