On Fri, 9 Oct 2026 03:05:24 GMT, sendaoYan <[email protected]> wrote:

>> Shiv Shah has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Say why the retry works
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects003/referringObjects003.java
>  line 195:
> 
>> 193:         // its handles to them a little later, so one collection may 
>> not be enough.
>> 194:         for (int i = 0; i < 5; i++) {
>> 195:             forceGC();
> 
> It'd be worth spelling this out in the comment: the retry works because the 
> handle is released in the meantime, i.e. it depends on the time forceGC() 
> takes. A lighter GC here would look like an obvious cleanup but would break 
> the fix.

Added that to the comment

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33261#discussion_r4252740248

Reply via email to