On Tue, 1 Sep 2026 19:16:37 GMT, Daniel D. Daugherty <[email protected]> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Updated after review
>
> src/hotspot/share/runtime/objectMonitor.cpp line 2593:
> 
>> 2591: //     ...
>> 2592: //     [55] = '\0'
>> 2593: //   }
> 
> If you remove the padding after `_object`, then `_pad_buf0` can go.

Removed the padding, and `_pad_buf0`.

> test/hotspot/gtest/runtime/test_objectMonitor.cpp line 34:
> 
>> 32: 
>> 33:     EXPECT_GE((size_t) in_bytes(ObjectMonitor::owner_offset() - 
>> ObjectMonitor::object_offset()), cache_line_size)
>> 34:         << "the _object and _owner fields are closer "
> 
> If you remove the padding after `_object`, then this test also needs to be 
> removed.

Removed the padding, and the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32573#discussion_r3915560194
PR Review Comment: https://git.openjdk.org/jdk/pull/32573#discussion_r3915549956

Reply via email to