On Thu, 2 Jul 2026 13:22:43 GMT, Kieran Farrell <[email protected]> wrote:
>> This patch adds a new jcmd diagnostic command, `VM.show_settings`, to make >> the existing -`XshowSettings` output available from a running VM. The >> command accepts the same sections as`XshowSettings` (all, vm, properties, >> locale, security, system, security:all, security:properties, >> security:providers, security:tls). >> >> HotSpot registers the new diagnostic command, validates the requested >> section, then calls into `sun.launcher.LauncherHelper` to reuse the existing >> show settings formatting and return the result as bytes for the jcmd stream. >> The VM settings path also passes hotspots `InitialHeapSize`, `MaxHeapSize`, >> and Java thread stack size into the Java helper. A new jcmd test covers VM, >> properties, security TLS, and invalid-input output. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Kieran Farrell has updated the pull request incrementally with one additional > commit since the last revision: > > extend test coverage and code clean up src/hotspot/share/services/diagnosticCommand.cpp line 487: > 485: strcmp(sec, "security:providers") != 0 && > 486: strcmp(sec, "security:tls") != 0 && > 487: strcmp(sec, "system") != 0) { Drive by comment: `-XshowSettings:system` is Linux only. Should this be accounted for here? On non-Linux it falls back to "all". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r3519140346
