On Wed, 10 Jun 2026 16:28:26 GMT, Vladimir Kozlov <[email protected]> wrote:

>> src/hotspot/cpu/x86/vm_version_x86.cpp line 856:
>> 
>>> 854: // Note that it can be overridden by vendors in 
>>> set_vendor_specific_vm_config().
>>> 855: void VM_Version::set_vendor_agnostic_vm_config() {
>>> 856:   if (FLAG_IS_DEFAULT(IntelJccErratumMitigation)) {
>> 
>> This doesn't sound like it is a vendor agnostic check??
>
> For testing purpose `IntelJccErratumMitigation` flag can be specified on 
> command line to test corresponding code on any x86 CPUs. So we have to 
> process it here.
> 
> When default `compute_has_intel_jcc_erratum()` returns `false` for not 
> Intel's CPUs.

@ashu-mehra  may be add comment to avoid confusion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31301#discussion_r3389905597

Reply via email to