On Wed, 3 Jun 2026 04:35:34 GMT, David Holmes <[email protected]> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix setting of CopyAVX3Threshold >> >> Signed-off-by: Ashutosh Mehra <[email protected]> > > src/hotspot/cpu/x86/vm_version_x86.cpp line 856: > >> 854: // Note that it can be overridden by vendors in >> set_vendor_specific_vm_config(). >> 855: void VM_Version::set_vendor_agnostic_vm_config() { >> 856: if (FLAG_IS_DEFAULT(IntelJccErratumMitigation)) { > > This doesn't sound like it is a vendor agnostic check?? For testing purpose `IntelJccErratumMitigation` flag can be specified on command line to test corresponding code on any x86 CPUs. So we have to process it here. When default `compute_has_intel_jcc_erratum()` returns `false` for not Intel's CPUs. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31301#discussion_r3389886361
