On Thu, 21 May 2026 13:35:18 GMT, Thomas Stuefe <[email protected]> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert "renaming" >> >> This reverts commit c58a65577d446e92dc68d59227312f6135bcb32f. > > src/hotspot/share/runtime/os.hpp line 447: > >> 445: // The search begins at the provided start address. >> 446: // Returns true after the first contiguous resident region is found, >> otherwise false if none found. >> 447: static bool resident_in_range(address start, size_t size, address& >> resident_start, size_t& resident_size); > > I realized just now (again) that this API does not count resident space in a > range, but finds the first resident region within a range. I remember that > this name clash confounded me also back when I looked at NMT the first time. > > I therefore would rename it to "first_resident_in_range" and to adjust the > comment accordingly. Renamed it! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31124#discussion_r3283106867
