On Tue, 19 May 2026 14:02:35 GMT, Ashay Rane <[email protected]> wrote:
> Prior to this patch, the following tests failed when they were run using > MSys2/MinGW with the error "Unrecognized system!": > > - javax/script/ProviderTest > - javax/script/ScriptEngineOrder > - tools/launcher/ClassPathWildCard > - java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest > - java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest > - java/lang/instrument/appendToClassLoaderSearch/run_tests > > This patch fixes the problem by enabling support for MSys2 required for > running these tests. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). These look okay. I was wondering about `isCygwin=true` bit. But I don't think that flag is used anywhere? The direct string search for `isCygwin` yields no interesting hits. So it is irrelevant for MSYS2/MINGW path either way. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31204#pullrequestreview-4319789929
