On Fri, 15 May 2026 15:53:31 GMT, Chris Plummer <[email protected]> wrote:
>> Manuel Hässig has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 49 commits: >> >> - Merge branch 'master' into remove-jvmci >> - Remove graal from test/langtools >> - Remove jvmci and graal from test/lib >> - Remove jvmci and graal from test/jdk/jdk/jfr >> - Remove jvmci from test/jdk/tools/jlink >> - Remove jvmci and graal from test/jdk/jdk/modules >> - Remove jvmci and graal frmo test/jdk/java/lang >> - Remove graal from test/jdk/javax >> - Remove jvmci and graal from test/jdk/com/sun/jdi >> - Remove jvmci and graal from test/hotspot/jtreg/runtime >> - ... and 39 more: https://git.openjdk.org/jdk/compare/061bd076...0100264f > > test/jdk/javax/management/generified/GenericTest.java line 82: > >> 80: checked(((MBeanServerConnection) >> mbs).queryNames(null, null), >> 81: ObjectName.class); >> 82: // If new MBean is registered while the test is running, >> names1, > > I wonder if the extra 2nd attempt logic should be removed. It was added by > [JDK-8242239](https://bugs.openjdk.org/browse/JDK-8242239) specifically for > Graal. @kevinjwalls? Yes looks like the Graal MBean was registered later, which was novel, and tripped up the test. I don't think it's a problem to leave that retry logic in the test. This seems harmless and retrying could be useful... (yes, maybe never...). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30834#discussion_r3249834174
