On Fri, 17 Apr 2026 20:43:32 GMT, Evgeny Astigeevich <[email protected]> 
wrote:

> This PR adds blobs/nmethods/adapters stats per code heap in 
> CodeCahe::print_summary:
> 
> CodeHeap 'non-profiled nmethods': size=118592Kb used=370Kb max_used=370Kb 
> free=118221Kb
>  bounds [0x00007f2093d3a000, 0x00007f2093faa000, 0x00007f209b10a000]
>  blobs=397, nmethods=397, adapters=0, full_count=0
> CodeHeap 'profiled nmethods': size=118592Kb used=2134Kb max_used=2134Kb 
> free=116457Kb
>  bounds [0x00007f208c109000, 0x00007f208c379000, 0x00007f20934d9000]
>  blobs=1091, nmethods=1091, adapters=0, full_count=0
> CodeHeap 'non-nmethods': size=8580Kb used=4461Kb max_used=4506Kb free=4118Kb
>  bounds [0x00007f20934d9000, 0x00007f2093949000, 0x00007f2093d3a000]
>  blobs=478, nmethods=0, adapters=387, full_count=0
> CodeCache: size=245764Kb, used=6965Kb, max_used=7010Kb, free=238796Kb
>  total_blobs=1966, nmethods=1488, adapters=387, full_count=0
> Compilation: enabled, stopped_count=0, restarted_count=0
> 
> 
> This information is useful for debugging CodeCache.
> 
> Testing: fastdebug, tier1-tier2 passed.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Good. One comment.

src/hotspot/share/code/codeCache.cpp line 1872:

> 1870:                    p2i(heap->high_boundary()));
> 1871: 
> 1872:       full_count += get_codemem_full_count(heap->code_blob_type());

Unfortunately `get_codemem_full_count()` is also used by JFR. Otherwise we 
could remove it.

src/hotspot/share/code/codeCache.cpp line 1891:

> 1889:                    "Kb, max_used=" JULONG_FORMAT "Kb, free=" 
> JULONG_FORMAT "Kb",
> 1890:                    total_size, total_used, total_max_used, total_free);
> 1891:       st->print_cr(" total_blobs=" UINT32_FORMAT ", nmethods=" 
> UINT32_FORMAT

Should we use ' ': `total blobs` since `total` relates to all counts in this 
line,

-------------

PR Review: https://git.openjdk.org/jdk/pull/30803#pullrequestreview-4132559508
PR Review Comment: https://git.openjdk.org/jdk/pull/30803#discussion_r3103684613
PR Review Comment: https://git.openjdk.org/jdk/pull/30803#discussion_r3103676091

Reply via email to