On Thu, 2 Apr 2026 03:13:16 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Prior to this patch, both the build and the tests included several >> references to C:/. References in the build assumed that Windows is >> installed on C:/, which causes the build to fail when Windows is >> installed on a different drive. The references among tests assumed that >> the C:/ drive exists, which although mostly correct, is not guaranteed, >> making the tests fragile. >> >> This patch fixes the build references to use the `SYSTEMROOT` >> environment variable, which points to the Windows installation path, >> instead of hardcoded references to C:/Windows. This patch also updates >> tests to not use the presence of C:/ to detect Windows (instead relying >> on the output of `uname -s`) and to not assume that every Windows >> installation has a C:/. > > please double check the issue with WSL Thanks @mrserb I was going to boost the number of reviewers myself. @raneashay your integration request was premature. When a change touches a number of areas it is usual to ensure someone from each area has a chance to review it. In particular here we need an okay from the build team. Thanks ------------- PR Comment: https://git.openjdk.org/jdk/pull/30523#issuecomment-4174865321
