On Mon, 9 Mar 2026 18:23:30 GMT, Chris Plummer <[email protected]> wrote:

>> SA should follow HotSpot implementation, so that code should be included 
>> basically. However it is not needed in this case. Thus I left comment the 
>> reason.
>
> I still don't follow. Are you saying that map->in_cont() will always return 
> true so you don't need the walk_cont related code?

I just want to say we don't need to copy `return 
map->stack_chunk()->sender(*this, map)` to SA from HotSpot because 
`map->in_cont()` should be `false` in use case of SA.

`in_cont()` returns `true` if `_chunk` is not `NULL`, but it would not happen 
in the use case of SA because `RegisterMap` would not be initialized with 
`WalkContinuation::include`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30107#discussion_r2908516241

Reply via email to