Re: RFR: 8376295: "assert(BytecodeVerificationRemote) failed: Should not be here" when running class redefinition test with -XX:-BytecodeVerificationRemote

[Serguei Spitsyn]

On Thu, 29 Jan 2026 01:35:57 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:

> Hi
> 
> Please review following fix that remove incorrect assertion.
> 
> Verification should be always done for redefined classes, and is called 
> `bool Verifier::verify(InstanceKlass* klass, bool should_verify_class, TRAPS)`
> where `should_verify_class` and `is_eligible_for_verification` define if 
> verification should be done or not.
> Thus, seems it doesn't make a sense to check `BytecodeVerificationRemote` 
> during verification.
> 
> Verified that class redefinition tests pass now with 
> TEST_VM_OPTS="-XX:-BytecodeVerificationRemote" and fastdebug

Looks good.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29476#pullrequestreview-3843433741