On Tue, 20 Jan 2026 11:29:41 GMT, Severin Gehwolf <[email protected]> wrote:

> Please review this test-only fix. For non-ascii vendor strings the hotspot 
> container tests fail in fastdebug because the encoding of the vendor string 
> doesn't match. Full details in 
> [JDK-8375471](https://bugs.openjdk.org/browse/JDK-8375471). In order to avoid 
> the assert, the containers need to set to an UTF-8 encoding. This patch 
> proposes to do so by setting `LANG=C.UTF-8`.
> 
> Thoughts?
> 
> **Testing:**
> - [x] GHA
> - [x] Linux container tests on cg v1 and cg v2 with a JDK build and vendor 
> string `Foo bar öÜß` and fastdebug. All pass. Most failed before.

test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java line 380:

> 378:         if (baseImage.contains("ubuntu") && DockerfileConfig.isUbsan()) {
> 379:             template += "RUN apt-get update && apt-get install -y 
> libubsan1\n";
> 380:         }

Should we update the copyright for 
test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29315#discussion_r2708015583

Reply via email to