On Mon, 12 Jan 2026 18:41:07 GMT, Larry Cable <[email protected]> wrote:

>> modified the pre-existing VM.classes jcmd to add a 'location' option, that 
>> when specified, will (natively) attempt to obtain the value (if non-null) of 
>> the location URL of the CodeSource of each classes ProtectionDomain.
>> 
>> effectively:
>> 
>> someObject.getClass().getProtectionDomain().getCodeSource().getLocation().toExternalForm()
>> 
>> (where interim oops are null-checked)
>
> Larry Cable has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   JDK-8327246: added test for VM.classes -location as per lmesnik

src/hotspot/share/oops/instanceKlass.cpp line 2401:

> 2399:         oop cs = pd->obj_field(csfd.offset());
> 2400: 
> 2401:         assert(cs !=nullptr && !cs->klass()->is_instance_klass(), "cs 
> klass is not InstanceKlass");

Should we be asserting it is an instanceklass?

(also int: cs != space nullptr while we are here)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29048#discussion_r2683759759

Reply via email to