On Wed, 7 Jan 2026 03:14:34 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve exception
>
> test/jdk/com/sun/tools/attach/TestWithoutDumpableProcess.java line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
>> 3: * Copyright (c) 2015, NTT DATA
>
> The Copyright year seems to be wrong?
Yes - I updated to 2026 in all of files.
> test/jdk/com/sun/tools/attach/TestWithoutDumpableProcess.java line 84:
>
>> 82: "--enable-native-access=ALL-UNNAMED",
>> 83: String.format("-D%s=%s", EXPECTED_PROP_KEY,
>> EXPECTED_PROP_VALUE),
>> 84: Debuggee.class.getName()
>
> The line 84 is not indented properly. I'd move it to line 83 as it is not
> that long.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28867#discussion_r2667021404
PR Review Comment: https://git.openjdk.org/jdk/pull/28867#discussion_r2667021695
